Nostr View

David @mleku - 2mo

hah. i have found a #bug in #realy someone has been sending delete events and somehow the a-tag unmarshal is triggering a nil pointer panic just instrumented the code with some logs to see if i can figure out what is happening, something to do with a-tag unmarshaling, which is the kind:pubkey:dtag thing

1
0
3

David @mleku - 2mo

i've also added nil guards to all the event kind type checkers that print the caller doing it but the panic trace was pretty clear it was coming from a delete event {"id":"ac9ee5549fb43413330efbf41fe2cb6ab1e824e565daed47cacec24fd3c985df","pubkey":"4dc2e570c54fef8313fa304f52974044ed6c128510052600a9b84d837b8126f9","created_at":1748051805,"kind":5,"tags":[["e","d0965ea9282c6e2357c38f2e7030c02a1e6b1c6cb823973554c2019d7a4db768"],["a","31234:4dc2e570c54fef8313fa304f52974044ed6c128510052600a9b84d837b8126f9:b4bc743d-c975-47e1-ad93-092068699b51"],["k","31234"],["alt","Deletion event"]],"content":"","sig":"1dd2877ffc4252e7683b4c633d1d7e9fcce6fecf752c989666578fe6224841fd7aca26e5c7a232219782bb30bb56358bc407f4297802cbd156426be0eca14d60"}] the thing is that the a tag in there looks correct so i think it's just because of how the unmarshal was constructing the list of results when fetching the tags hopefully whoever is sending these will do it again so i get this one squashed

1
0
3

David @mleku - 2mo

i think i have eliminated the panic though, every place that has or could access a nil pointer in the kinds library now has a guard that prints the location of the call that did it and returns false (since not there is not there) seems to have fixed it now but i'm monitoring

1
1
3

David @mleku - 2mo

not really sure how this never came up before but it's related to how the tags are implemented in realy - they are pointers to structs containing pointers to structs containing pointers to structs and if the pointer anywhere in that chain is nil there is something wrong with how the tag is being constructed, however, such structures also should have nil guards everywhere to be honest i would like to rewrite the tag handling to just be slices of slices of slices of bytes... the grammar checker in my IDE complains about me writing such texts but the retarded grammar checker doesn't know that this is not repetition but a description of what a 3 dimensional array is (yes, event tags are a 3 dimensional array)

1
1
3

David @mleku - 2mo

the other thing is as soon as i put nil guards on all the tag handling functions the bug has vanished, so, idk even if there was a bug the functions that were causing panic were searching for specific tags and found nothing so i guess they should be returning nil, probably i just closed up the upstream-most call passing down empty tags that had no results in them anyway

0
1
3

Silberengel @Laeserin - 2mo

😂 I get it tho. Error-handling and graceful edge-case handling never cease, just like testing.

1
0
3

David @mleku - 2mo

most programming languages don't follow the principle of fail fast tho go is the only language i know of where you are admonished vigorously to handle errors before you handle success, it's for this reason almost all apis of go have a separate error variable in the return, and there is such a thing as a success with error so the common model in OOP languages of having errors be a variant doesn't allow you to catch errors while otherwise the call succeeded, there is such a thing as nonfatal errors

0
0
3

David @mleku - 2mo

yeah, this has got me thinking... i've got a whole bunch of code written now, implementing the new design of event and signature... i'm gonna write a full set of tests on everything in it before i continue

1
0
3

David @mleku - 2mo

delay gratification cross all the i's and dot all the t's

0
0
3

David @mleku - 2mo

i'm not much for fighting but if you get a hold of me you will regret it, i know how much pain it causes me to smack my head... it's been smacked a bazillion times by me jumping up impulsively though i'm pretty sure i got the impulse problem from being exposed to organomanganese antifungals as an infant... and later on, i was eating fluoride tablets like lollies and eating gobs of margarine, along with the raw carrots and onions

0
0
3
Showing page 1 of 1 pages